Repository navigation
Conversation
The CSI parameter parser dropped ':' and merged the digits around it, so `ESC[4:0m` (underline off) was read as SGR 40 (black background) and `ESC[38:2::r:g:bm` was misparsed. Collect colon-separated sub-parameters (ITU T.416) and map them onto the semicolon forms the SGR handler already understands: `4:0` -> 24, `4:N` -> 4, `38/48:2[:cs]:r:g:b` and `38/48:5:n` -> their ';' equivalents. The underline colour (`58`) is accepted and ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSI parameter parser drops
:and merges the digits around it.ESC[4:0m(underline off) is read as SGR 40, a black background, and the underline is never cleared.ESC[38:2::r:g:bmis misparsed too.This collects colon-separated sub-parameters (ITU T.416) and maps them to the semicolon forms the handler already understands:
4:0to 24,4:Nto 4,38/48:2[:cs]:r:g:band38/48:5:nto their;equivalents. The underline colour (58) is accepted and ignored. Underline styles (curly and so on) are not rendered; they fall back to a plain underline.Tests cover each form.