Repository navigation
Conversation
--device now also accepts the address of a network camera, so an Android phone
running DroidCam can be used without a PC client:
marimapper_check_camera --device 192.168.1.20:4747
A bare host or host:port is treated as DroidCam (default port 4747, stream path
/video); a path can be added, and full http:// or rtsp:// URLs are passed through.
Plain camera indexes work exactly as before.
Network streams are opened with the FFmpeg backend with a 5 second open/read
timeout (an unreachable address used to block for far longer) and a one frame
buffer. Exposure and focus can't be set over a network stream; the existing
"failed to set exposure" warning covers that.
Tests parse the address forms and read frames from a local MJPEG server that
behaves like the DroidCam app.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
gunicsba
marked this pull request as ready for review
October 19, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--devicenow also takes the address of a network camera, so an Android phone running DroidCam can be used without installing a PC client:What changes
--deviceaccepts a camera index (as before),host[:port][/path], or a fullhttp:///rtsp://URL.host:portis treated as DroidCam: the port defaults to4747and the stream ishttp://<host>:<port>/video. A path can be added to override that.CAP_ANYis used if it is missing.Cameraitself still accepts whatever it accepted before (indexes, file paths, image sequences), so nothing about the existing code paths changes. The address parsing lives in the argparsetype.Testing
RuntimeError. All 20 tests intest_camera.pypass, including the existing ones.flake8 .is clean, andblack --checkis clean on the files I touched. The newestblackalso wants to reformat four other files, which I left alone.marimapper_check_camera --device <phone ip>:4747detects an LED held up to the camera.Notes
/videopath and the default port come from how DroidCam is used with OpenCV in practice; I couldn't find an official DroidCam page for them.🤖 Generated with Claude Code