Repository navigation
Conversation
The scan used to show a single progress bar. It now shows a line for the whole scan and a line for every camera: how many leds that camera has detected out of those scanned (with a bar and a percentage), and where it has gaps. A gap is a run of leds a camera missed between two it saw. Gaps short enough for the reconstruction to interpolate (--interpolation_max_fill) are marked fillable, longer ones too long with the longest one named, and the leds of every too-long gap are listed when the scan ends. A camera that has found none of the first 20 leds gets a hint about what to check (is it looking at the leds, is the room dark, --exposure and --threshold). The lines are redrawn in place on a terminal, cut to the width of the window, with block characters only where the terminal can show them. When the output isn't a terminal (a log or a pipe) only the final state is written. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scan showed one progress bar, so you couldn't tell if the camera was even seeing the LEDs until a scan was done. This replaces it with a line for the whole scan and a line for every camera:
It works with one camera too (an overall line and a camera line). The per camera lines are what you need as soon as there are several cameras (see #91, multi camera), but nothing here depends on it.
What it shows
--interpolation_max_fill) are markedfillable, longer onestoo long, with the longest named. When the scan ends the LEDs of every too long gap are listed.--exposureand--threshold.How it is drawn
I first used
tqdmbars, but with several lines of changing width and colour they came out in the wrong order and with leftover text when the scan finished (in a Windows terminal). So the lines are redrawn by a smallScanDisplayclass: the whole block is redrawn in place, each line is cut to the width of the window (a wrapped line would break the cursor movement), and messages are printed above the block. Block characters are only used when the terminal can show them. When the output isn't a terminal (a log, a pipe) it only writes the final state, with no colour or cursor codes.Testing
Tests cover the gap logic (leading and trailing misses, fillable against too long), the line for each camera in a scan with several cameras, the hint, the final report and the redrawing (in place, message above, trimmed width, no terminal, no block characters).
flake8is clean and the existing tests pass. I also ran it in a real terminal during real multi camera scans and it looks right.This touches
scanner.pyand the README in the same places as two other pull requests, #91 (multi camera) and #93 (--capture_only). They're independent but whichever lands second needs a small rebase. All three merged together pass all 74 tests.🤖 Generated with Claude Code