Repository navigation
fix(phantasialand): keep the signage position inside the park outline - #672
Merged
Merged
Conversation
/signage-snapshots takes the caller's position as loc=lat,lng and answers 403 FORBIDDEN for a position outside the park outline (a bad or missing token gets 401). The box the position was drawn from reached outside the outline at its south-west corner, and a retry re-sends the same position, so a poll that drew one failed after the full backoff window. Draw from a box that stays inside the outline instead. Adds `npm run probe:phantasialand`, a live check that draws through the park's own fetch and exits 1 on any refusal. The comments that blamed a rate limit now describe what the endpoint does. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/signage-snapshotstakes the caller's position asloc=lat,lngand answers 403 FORBIDDEN for a position outside the park outline (a bad or missing token gets 401). The box the position was drawn from reached outside the outline at its south-west corner, and a retry re-sends the same position, so a poll that drew one failed after the full backoff window.This draws from a box that stays inside the outline, and corrects the comments that blamed a rate limit.
Test plan
src/parks/phantasialand/__tests__/signageLocation.test.ts: the draw stays in the box at the extremes of the generator,fetchSignagesends what the generator produced, and the box stays clear of positions seen refusednpm run probe:phantasialandis a live check that draws through the park's own fetch and exits 1 on any refusal. It passes on the new box and fails on the old one🤖 Generated with Claude Code