Repository navigation
Conversation
The attractions listing carries a per-ride queue figure ("0 mins",
"5 mins"). It moves in coarse steps, mostly 0 and 5, and does not track
the line, so publishing it as a standby wait time reported a measurement
that is not one.
Rides now carry a status and no queue object. Status is decided as
before: a ride whose queue text holds a minute figure, 0 included, is
OPERATING; a ride with no figure is CLOSED. Show times and everything
else are unchanged.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream behaviour
The Ocean Park Hong Kong attractions page shows a queue figure per ride as text such as "0 mins" or "5 mins". The figure moves in coarse steps, mostly 0 and 5 (in a July capture of the page, 28 of 32 figures were 0 or 5 and the rest were 10 or 15), and it does not follow the length of the line. It behaves like a flag on the ride, not a measured queue.
Change
Rides no longer publish
queue.STANDBY.waitTime. A ride's live data is now its id and a status, with noqueueobject, so nothing downstream reads the figure as a measured wait.Status is decided exactly as before:
OPERATINGnullqueue field or text with no minute figure:CLOSEDThe status never depended on the value of the figure, only on whether one is present, so 0 and 5 give the same result.
parseQueueMinutesis kept for that presence check, and its comment now says the number is not a wait time.Show times, entities, schedules and everything else are unchanged.
Tests
In
src/parks/oceanpark/__tests__/oceanpark.test.ts:queue.STANDBY.waitTimenow assertqueueis absent and status is unchanged{id, status: 'OPERATING'}with noqueuekey{id, status: 'CLOSED'}queueon any rideThe new "no queue" tests failed before the change for the right reason (
{STANDBY: {waitTime: ...}}present). Full suite: 189 files, 4205 passed, 1 skipped. Typecheck clean.🤖 Generated with Claude Code