Skip to content

18.0 mig base external system http l - #5

Open
lfreeke wants to merge 12 commits into
18.0from
18.0-mig-base_external_system_http_l
Open

lfreeke wants to merge 12 commits into
18.0from
18.0-mig-base_external_system_http_l

Conversation

@lfreeke

@lfreeke lfreeke commented Oct 20, 2026

Copy link
Copy Markdown

No description provided.

@lfreeke

lfreeke commented Oct 21, 2026

Copy link
Copy Markdown
Author

@NL66278
I took the module from this merge request https://github.com/Therp/server-backend/tree/16.0-add-base_external_system_ms_client_assertion

I think this is the best because this is the branch with the abstract model, which is also the plan to introduce in Odoo 18 as I understand it all correctly.
I did cherry pick 2 commits f41c5a9 22223fe that should fix some small issues.

@NL66278 NL66278 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@NL66278

NL66278 commented Nov 6, 2026

Copy link
Copy Markdown

The tests tries to go to an OCA github page. However in current Odoo testing external http requests are blocked. Therefore the request.get method should be mocked, so it does not go outside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants