Conversation
On macOS the packages list is a wxDataViewCtrl whose checkbox column only changes on a click. VoiceOver sends one for VO+Space while interacting with the list, but a plain Space reached no handler at all, so a keyboard user could not tick anything (Timtam#28). Space on the selected row now runs the same toggle as a click: the model's set_value body moved into a shared closure that both call, and the toggle column's state is read through one helper, which also replaces the four copies of the group aggregate in get_value. Disabled rows are left alone, as with a click. A toggle made from code gives VoiceOver nothing to read, because the row it is on is rebuilt behind it. A small voiceover module posts NSAccessibilityAnnouncementRequestedNotification with the row's new state ("Checked" / "Unchecked", in all five locales). It uses CoreFoundation's toll-free bridged types, so no Objective-C runtime calls or new crates. Fixes Timtam#28 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
VoiceOver reads a control's new label or state only when the user moves to it, so three things RABBIT changes on its own went unheard on macOS: - ticking a package can show or hide the REAPER-language and Spanish variant dropdowns below the list, off to the side of the row the user is on; - the progress page's status line moves from package to package while focus sits on the log; - a failed version check rewrites the status line while focus stays on the gauge. Each is now announced through the voiceover module added for Space toggles, which gains a priority: the answer to a key press interrupts, news the user didn't ask for waits for current speech. Only the start of each install and configuration step is spoken, not download lines, which change several times a second. A Space toggle folds its dropdown news into the same announcement, since a second one would cut the first off; a click or VO+Space, which VoiceOver already reads back, gets the dropdown news on its own, politely. The packages toggle now returns the dropdown lines instead of a bool; elsewhere than macOS `announce` does nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
VoiceOver reads a control's new label or state only when the user moves to it, so three things RABBIT changes on its own went unheard on macOS. Each is now announced:
The announcement helper gains a priority: the answer to a key press interrupts, news the user didn't ask for waits. A Space toggle folds its dropdown news into its own "Checked" announcement, because a second announcement would cut the first off. A click or VO+Space, which VoiceOver already reads back, gets the dropdown news on its own, after it.
New locale keys in all five languages. On anything other than macOS,
announcedoes nothing.Testing
Validated on macOS with VoiceOver (fr-FR): dropdowns appearing and disappearing through Space and VO+Space, and a full install run. The version-check failure path compiles, but I couldn't trigger it by hand.
Whether announcements are too chatty is a taste call, so it's easy to drop any one of the three.
🤖 Generated with Claude Code