the attribute in the relationshipStructure should not be id but name… - #1056
Open
ue71603 wants to merge 2 commits into
Open
the attribute in the relationshipStructure should not be id but name…#1056ue71603 wants to merge 2 commits into
ue71603 wants to merge 2 commits into
Conversation
ue71603
added
the
bug
skinkie
reviewed
Aug 5, 2026
| <xsd:documentation>Abstract Type for a serialisation of a NeTEx relationship.</xsd:documentation> | ||
| </xsd:annotation> | ||
| <xsd:attribute name="id" type="RelationshipId"> | ||
| <xsd:attribute name="nameOfClass" type="RelationshipId"> |
Contributor
Author
There was a problem hiding this comment.
I think it is. have a look what RelationshipId really is.
Contributor
Author
There was a problem hiding this comment.
it is derived from NameOfClass.
Contributor
There was a problem hiding this comment.
RelationshipId isn't the right name... but you are right then.
Contributor
Author
|
I try to change the name and we see if something breaks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in reality only name of classes are allowed and so the attribut can't be called id, but should be called nameOfClass.
as in most cases like nobody uses id, but if you do, then it must be a NameOfClass.