Fix launcher not disabling off the field - #197
Open
nlaverdure wants to merge 1 commit into
Open
Conversation
The launcher's default command had regressed back to unconditionally initializing the hood and aiming (from #533cacc), silently undoing the #97 fix that let the Zorro left dial disable the launcher when off the FMS. Restore the default command to stop the launcher so the dial (and FMS-attached override) are the only things that turn it on. That default previously masked a gap in the Xbox and keyboard driver bindings, which have no dial and never explicitly enabled the launcher. Give them an always-true trigger so the launcher aims unconditionally whenever either is the active driver, matching the FMS-attached behavior on the Zorro path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
./gradlew compileJavapasses🤖 Generated with Claude Code