Skip to content

Fix launcher not disabling off the field - #197

Open
nlaverdure wants to merge 1 commit into
mainfrom
fix/launcher-disable-default-command
Open

Fix launcher not disabling off the field#197
nlaverdure wants to merge 1 commit into
mainfrom
fix/launcher-disable-default-command

Conversation

@nlaverdure

Copy link
Copy Markdown
Member

Summary

  • The launcher's default command had regressed back to unconditionally initializing the hood and aiming (introduced in VAALE updates #141), silently undoing the Allow launcher to be disabled in some cases #97 fix that let the Zorro left dial disable the launcher when off the FMS. Restored the default command to stop the launcher so the dial (and FMS-attached override) are the only things that turn it on.
  • That buggy default was incidentally masking a gap in the Xbox and keyboard driver bindings, which have no dial and never explicitly enabled the launcher. Added an always-true trigger to each so the launcher aims unconditionally whenever either is the active driver — matching the FMS-attached behavior on the Zorro path.

Test plan

  • ./gradlew compileJava passes
  • On the bench, confirm turning the Zorro left dial down stops the launcher (flywheel spins down, turret/hood stop tracking) when not FMS-attached
  • Confirm the launcher still aims continuously with Xbox set as the active driver
  • Confirm the launcher still aims continuously with the sim keyboard driver
  • Confirm FMS-attached (or simulated) still forces the launcher on regardless of dial position on the Zorro path

🤖 Generated with Claude Code

The launcher's default command had regressed back to unconditionally
initializing the hood and aiming (from #533cacc), silently undoing the
#97 fix that let the Zorro left dial disable the launcher when off the
FMS. Restore the default command to stop the launcher so the dial (and
FMS-attached override) are the only things that turn it on.

That default previously masked a gap in the Xbox and keyboard driver
bindings, which have no dial and never explicitly enabled the launcher.
Give them an always-true trigger so the launcher aims unconditionally
whenever either is the active driver, matching the FMS-attached
behavior on the Zorro path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant