Repository navigation
Move QC to consensus process - #11
Merged
OlivierBakker merged 2 commits intoAug 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QC metrics implementation and integration:
src/cnmf/qc.pymodule that computes various QC metrics (e.g., pairwise E-distance, clustering metrics, variance explained), saves annotated outputs, and generates heatmap visualizations.run_qcinsrc/cnmf/cnmf.py, ensuring that QC metrics are calculated and saved after consensus clustering. [1] [2]Dependency and packaging updates:
setup.pyto include new dependencies required for QC metrics and plotting, specificallyseabornandtqdm.Testing and reproducibility:
tests/test_consensus_qc.pyto verify the correctness of E-distance calculations and the full QC output, using synthetic data to ensure results match a known reference implementation. The tests check both the annotation and E-distance outputs, as well as the creation of the heatmap plot.Tracking
Closes JerryIshihara/sc-blipper#14