Skip to content

Move QC to consensus process - #11

Merged
OlivierBakker merged 2 commits into
TrynkaLab:mainfrom
JerryIshihara:optimize/consensus-qc-caching
Aug 20, 2026
Merged

OlivierBakker merged 2 commits into
TrynkaLab:mainfrom
JerryIshihara:optimize/consensus-qc-caching

Conversation

@JerryIshihara

@JerryIshihara JerryIshihara commented Aug 19, 2026 •

Copy link
Copy Markdown

QC metrics implementation and integration:

  • Added a new src/cnmf/qc.py module that computes various QC metrics (e.g., pairwise E-distance, clustering metrics, variance explained), saves annotated outputs, and generates heatmap visualizations.
  • Integrated the QC step into the consensus workflow by importing and calling run_qc in src/cnmf/cnmf.py, ensuring that QC metrics are calculated and saved after consensus clustering. [1] [2]

Dependency and packaging updates:

  • Updated setup.py to include new dependencies required for QC metrics and plotting, specifically seaborn and tqdm.

Testing and reproducibility:

  • Added a new test suite tests/test_consensus_qc.py to verify the correctness of E-distance calculations and the full QC output, using synthetic data to ensure results match a known reference implementation. The tests check both the annotation and E-distance outputs, as well as the creation of the heatmap plot.

Tracking

Closes JerryIshihara/sc-blipper#14

@OlivierBakker
OlivierBakker merged commit fb5f38f into TrynkaLab:main Aug 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate cNMF QC metrics into consensus and retire the standalone CNMFQC process

2 participants