Repository navigation
Add reconstruction error calculation with filtered spectra - #12
Merged
OlivierBakker merged 2 commits intoAug 25, 2026
Merged
Conversation
JerryIshihara
marked this pull request as draft
August 25, 2026 09:05
JerryIshihara
force-pushed
the
optimize/consensus-qc-caching
branch
from
August 25, 2026 09:14
8a5892c to
22eac9b
Compare
JerryIshihara
marked this pull request as ready for review
August 25, 2026 09:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New synthetic test fixture and infrastructure:
generate_synthetic_dataset.pyto create a deterministic synthetic three-program cNMF dataset, including known ground-truth usages and spectra, and outputs in both AnnData and TSV formats.generate_original_results.pyto automate running cNMF on the synthetic dataset, capturing outputs at each stage, tracking NMF iteration counts, and generating a manifest for reproducibility.manifest.yaml) and all necessary input and reference output files, includinggenes.txt,synthetic_counts.tsv,true_spectra.tsv, andtrue_usages.tsv, to enable deterministic and transparent regression testing. [1] [2] [3] [4] [5] [6] [7]QC pipeline improvements:
run_qcfunction insrc/cnmf/qc.pynow accepts and processes normalized counts and refit usages, computes R², SSE, and TSS metrics, and includes them in the QC annotation output. [1] [2]