Repository navigation
Add row tiling in the GPU Coordinate Descent (CD) NMF solver - #14
Merged
OlivierBakker merged 1 commit intoOct 2, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for row tiling in the GPU Coordinate Descent (CD) NMF solver, enabling the processing of large matrices in manageable row windows to better fit GPU memory constraints. The changes add a new
--gpu-row-tiling-ratioargument, implement a tiling utility module, and refactor the CD solver to use row tiling when appropriate. These improvements allow for automatic or user-specified tiling ratios, improving scalability and memory efficiency for large datasets.Row tiling support and solver refactoring:
--gpu-row-tiling-ratioto the command-line interface, allowing users to specify the row tiling ratio for GPU solvers, with support for automatic VRAM sizing or explicit ratios. [1] [2] [3]tiling.pythat provides logic for determining row window sizes based on available GPU memory, copying data between host and device, and iterating over row windows.solver_cd.pyto utilize row tiling: replaced full-matrix operations with windowed operations, added memory budgeting, and adjusted the fitting routines to stream data in windows when necessary. This includes new helper functions for windowed computation and stopping criteria. [1] [2] [3]tilingmodule and ensure it is available to the GPU NMF solver. [1] [2]Configuration and validation: