fix(runner): release the file teardown when stop-on-failure halts - #1328
Merged
Chemaclass merged 1 commit intoAug 19, 2026
Merged
Conversation
--stop-on-failure ends a sequential run with `exit` from inside the test loop, so the loop's own tear_down_after_script call was never reached and whatever set_up_before_script acquired was leaked. Track the file whose teardown this shell still owes, and settle the debt from the exit path before the summary and before the temp dirs a hook may still be reading. Gated on the file declaring the hook: with none declared the hook call prints a blank line, and emitting that from the halt path would change the output of every halted run. Turning the exit into a loop flag was the other option. It reroutes the halt through a path guarded by parallel::is_enabled, so it would rewrite all five stop-on-failure snapshots and start writing reports sequentially, neither of which this fix is about. Closes #1321
Chemaclass
deleted the
fix/1321-stop-on-failure-skips-tear-down-after-script
branch
August 19, 2026 18:32
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #1321
--stop-on-failureends a sequential run withexitfrom inside the test loop, so the loop's owntear_down_after_scriptcall is never reached. Whateverset_up_before_scriptacquired is leaked, and nothing in the output says the hook was skipped.💡 Changes
parallel::is_enabled, so it would rewrite all five stop-on-failure snapshots and start writing reports sequentially. Neither belongs in this fix.