Skip to content

fix(herdr): Honor tab display base in new-tab suggestions - #58

Merged
Unique-Divine merged 1 commit into
mainfrom
fix/herdr-new-tab-index-base
Oct 11, 2026
Merged

Unique-Divine merged 1 commit into
mainfrom
fix/herdr-new-tab-index-base

Conversation

@Unique-Divine

Copy link
Copy Markdown
Owner

Fix Herdr new-tab suggestions for zero-based indexing

Make both tab-creation dialogs suggest 6 when the workspace has tabs indexed 0 through 5, instead of suggesting 7.

Rationale

The keyboard dialog and tab context menu hard-code a one-based suggestion even when the tab bar uses zero-based indexes. Both dialogs should use the existing method tab_display_index_base() so the suggested name follows the same presentation rule. Default and mixed bindings retain one-based suggestions.

Key Changes

  1. Use the configured display base in both dialogs, counting only tabs in the target workspace.
  2. Cover both creation paths with real snapshots, including a context-menu target outside the focused workspace. Accepting the suggestion still sends label: None; editing it sends a custom name. Public tab IDs and numbering retain their upstream meaning.
  3. Record tab-creation suggestions in the vendored fork's local-change notes.

The full local check encounters two unrelated clipboard tests that read the Windows clipboard before their fake X11 commands on WSL. The remaining suite passes with those two tests excluded. Windows cross-lint is unavailable because this machine lacks the SDK configuration.

@Unique-Divine Unique-Divine added bug Something isn't working prio-p2-normal Priority: Normal A-ux Area: Solve friction in apps and wallets; improve acquisition, activation, referrals, and retention labels Oct 11, 2026
@Unique-Divine
Unique-Divine merged commit 8c8ecd0 into main Oct 11, 2026
2 checks passed
@Unique-Divine
Unique-Divine deleted the fix/herdr-new-tab-index-base branch October 11, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ux Area: Solve friction in apps and wallets; improve acquisition, activation, referrals, and retention bug Something isn't working prio-p2-normal Priority: Normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(herdr): New tab dialog ignores zero-based indexing

1 participant