Repository navigation
fix(herdr): Honor tab display base in new-tab suggestions - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Herdr new-tab suggestions for zero-based indexing
Make both tab-creation dialogs suggest
6when the workspace has tabs indexed0through5, instead of suggesting7.Rationale
The keyboard dialog and tab context menu hard-code a one-based suggestion even when the tab bar uses zero-based indexes. Both dialogs should use the existing method
tab_display_index_base()so the suggested name follows the same presentation rule. Default and mixed bindings retain one-based suggestions.Key Changes
label: None; editing it sends a custom name. Public tab IDs and numbering retain their upstream meaning.The full local check encounters two unrelated clipboard tests that read the Windows clipboard before their fake X11 commands on WSL. The remaining suite passes with those two tests excluded. Windows cross-lint is unavailable because this machine lacks the SDK configuration.