Adds AV Tests and Caption Functionality by K8Sewell · Pull Request #1796 · UniversalViewer/universalviewer

K8Sewell · 2026-07-02T21:11:49Z

Description of what you did:

Added tests for AV media
Added functionality to read transcripts from cookbook examples

Related Issue

vercel · 2026-07-02T21:11:55Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
universalviewer	Ready	Preview	Sep 8, 2026 7:36pm UTC
universalviewer.dev	Ready	Preview	Sep 8, 2026 7:36pm UTC

K8Sewell · 2026-07-02T21:16:11Z

    return typeGroup === "audio" || typeGroup === "video";
  }

-  // vtt, srt, csv


Was unable to find support for csv.

Have added tests that confirm functionality of both vtt and srt.

K8Sewell · 2026-07-02T21:17:20Z

      return false;
    }

-    const captionTypes = new Set<String>(["text/vtt", "text/srt"]);


Did not lose this. It's just higher up in the file now - https://github.com/UniversalViewer/universalviewer/pull/1796/changes#diff-cb64973a8a5a2e0eac4714d6ee79b3016b2f2e7b76e35a803c9f28b4bf197b16R30

demiankatz · 2026-07-03T10:54:20Z

Thanks, @K8Sewell, this is great! I haven't had a chance to look closely since I'm preparing to leave for my trip and need to choose my battles -- but I'll be happy to look closer when I get back if you want me to. In the meantime, I imagine that @LanieOkorodudu might be a good candidate for reviewing, since she's been more heavily involved in test code lately and probably has some good insights!

LanieOkorodudu · 2026-07-03T13:37:12Z

+      });
+    }, 60000);
+
+    it("loads the AV manifest into the mediaelement player", async () => {


@K8Sewell, Thanks for putting this together, Do you think it's worth adding the canvas title displays "Video Example 3", and that the video can actually play, continue for around 10 seconds, and then pause successfully.

@LanieOkorodudu thank you so much for this suggestion! I implemented it in the reintegrate AV PR but forgot to add them here as well. Will get that fixed asap and will re-request your review when they are ready. Thanks again!

I've added a play and pause test to the first AV manifest but to conserve speed of our tests I only included it for that single manifest. If you think I should add it for multiple I can certainly do that. Because the other tests of the other manifests confirm the loading I thought one play/pause expectation was sufficient given the 10 second time expenditure but am happy to defer to what you think is best! Really appreciate your insight!

Okay we probably leave this one to just play/pause. Thanks for all your work here.

LanieOkorodudu · 2026-07-03T13:42:48Z

+      });
+
+      // Play/pause button.
+      const playButton = await avPage.$(


Same here, like play for 10 seconds and and pause to confirm the video is actually play for seconds.

Fix incoming.

I wasn't sure with the 10 second time expenditure if it should be included for each manifest so I only included one but will happily update for each to have that expectation if you think that is better.

I could also shorten the time to 3 seconds or something like that if you would prefer.

Thanks @K8Sewell. yes you are aright 3 sec is okay to confirm the video actually play.

LanieOkorodudu · 2026-07-03T13:45:49Z

+      });
+    }, 60000);
+
+    it("loads the AV manifest into the AV center panel", async () => {


Also confirmed that the title has "Preludio e Coro d'introduzione – Bel conforto al mietitore" as it loaded.

Thank you for confirming this! I can add an expectation for this as well.

I ended up adding tests for each manifest's title. Thank you for this suggestion!

LanieOkorodudu · 2026-07-03T14:07:47Z

I really like the approach of creating a separate folder for each component to test. It makes everything much easier to maintain. Thanks! @K8Sewell

K8Sewell · 2026-09-08T15:56:06Z

I really like the approach of creating a separate folder for each component to test. It makes everything much easier to maintain. Thanks! @K8Sewell

Happy to! Hopefully this is just the start of adding many more helpful tests. :)

K8Sewell · 2026-09-08T19:49:59Z

May be able to close ticket #747 and PR #95 with this work if accepted.

demiankatz

Thanks, @K8Sewell, and sorry it has taken me so long to get back to this. I know @LanieOkorodudu is excited to get the new testing structure in place so she can build some more of her work on top of it!

See below for a few comments, questions and suggestions.

It may also be a good idea to try merging the latest dev branch into this branch to make sure that changes in, e.g., #1856 haven't broken anything here.

demiankatz · 2026-09-22T18:08:44Z

+// AV (audiovisual) manifest for AV-specific behaviour. A simple single-file
+// AV manifest (no ranges) is rendered by the mediaelement extension.
+const AV_VIDEO_MANIFEST =
+  "https://iiif.io/api/cookbook/recipe/0003-mvm-video/manifest.json";


It makes me slightly nervous to depend on an external URL for our test -- but I guess even if we copied this manifest locally, we would still rely on external servers for the actual video content, so maybe it's unavoidable.

Just wondering if we should consider creating local copies of anything, or if we're confident in relying on iiif.io -- the advantage to the local copy is it should be more stable (e.g. a test won't unexpectedly fail because an upstream manifest changed unexpectedly), though conversely, this means that we would have to manually synchronize any future recipe updates.

I don't want to hold up the PR with a long debate about this -- I can be persuaded either way -- but just wanted to raise the issue to see if anyone has strong opinions.

demiankatz · 2026-09-22T18:09:02Z

+const AV_SUPPLEMENTING_EXTERNAL_MANIFEST = `${BASE_URL}/test-fixtures/supplementing-external-captioned-video-manifest.json`;
+
+const viewerUrl = (manifestUrl) => {
+  //const separator = BASE_URL.includes("#?") ? "&" : "#?";


This doesn't seem to be needed:

Suggested change

//const separator = BASE_URL.includes("#?") ? "&" : "#?";

demiankatz · 2026-09-22T18:17:33Z

+  if (!label || typeof label === "string") {
+    return label || undefined;
+  }
+  const values = label[Object.keys(label)[0]];


Do we really want to pick the first key arbitrarily? Should we try to match the selected user language, or am I misunderstanding what's going on here?

demiankatz · 2026-09-22T18:23:27Z

+  // over https — an http -> https upgrade redirect whose 301 response lacks
+  // CORS headers is blocked by the browser even though its destination is
+  // readable.
+  async resolveCaptionSource(src: string): Promise<string> {


This seems promising as a possible resolution to the problems I encountered when testing #1298 on Villanova's https://digital.library.villanova.edu/Item/vudl:829943/Manifest manifest. I'll be interested to try that PR again after this one is merged!

K8Sewell added 3 commits July 2, 2026 15:58

Add AV tests and cookbook transcript display

f3ee2b2

Reorganize tests per media type

9bfeb29

Linting

b8d2c21

K8Sewell commented Jul 2, 2026

View reviewed changes

K8Sewell marked this pull request as ready for review July 2, 2026 21:53

LanieOkorodudu mentioned this pull request Jul 3, 2026

Reintegrate iiif-av-component #1795

Open

1 task

LanieOkorodudu reviewed Jul 3, 2026

View reviewed changes

Resolve merge conflicts

ffa22cd

vercel Bot deployed to Preview – universalviewer.dev August 28, 2026 17:55 View deployment

vercel Bot deployed to Preview – universalviewer August 28, 2026 17:55 View deployment

demiankatz added this to Universal Viewer Community Board Sep 3, 2026

demiankatz moved this to In testing in Universal Viewer Community Board Sep 3, 2026

K8Sewell added 2 commits September 8, 2026 11:29

Merge branch 'dev' into issue-1750-add-av-tests

69f1a6d

Add play and pause test

4407f1a

vercel Bot deployed to Preview – universalviewer September 8, 2026 17:33 View deployment

vercel Bot deployed to Preview – universalviewer.dev September 8, 2026 17:33 View deployment

Add tests for srt captions

1c63ced

vercel Bot deployed to Preview – universalviewer September 8, 2026 18:34 View deployment

vercel Bot deployed to Preview – universalviewer.dev September 8, 2026 18:35 View deployment

Add srt fixtures

1d55302

vercel Bot deployed to Preview – universalviewer.dev September 8, 2026 18:36 View deployment

vercel Bot deployed to Preview – universalviewer September 8, 2026 18:36 View deployment

Add expectations for av titles

d550cee

vercel Bot deployed to Preview – universalviewer September 8, 2026 19:36 View deployment

vercel Bot deployed to Preview – universalviewer.dev September 8, 2026 19:36 View deployment

K8Sewell requested a review from LanieOkorodudu September 8, 2026 19:47

demiankatz requested changes Sep 22, 2026

View reviewed changes

Uh oh!

Conversation

K8Sewell commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of what you did:

Related Issue

Uh oh!

vercel Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

demiankatz commented Jul 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LanieOkorodudu commented Jul 3, 2026

Uh oh!

K8Sewell commented Sep 8, 2026

Uh oh!

K8Sewell commented Sep 8, 2026

Uh oh!

demiankatz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

K8Sewell commented Jul 2, 2026 •

edited

Loading

vercel Bot commented Jul 2, 2026 •

edited

Loading