[alexanto]

Description

• removed unused fn normalized_hash and unused mmh3 dependency
• start using UnleashEngine.get_spec_version()
• made url validation to be an explicit check in the __post_init__
  • this is because today we only catch bad urls if register fails and reraises the client specific url exceptions, this is not great because if disable_registration=True is set then we just swallow it. i want to let the user inject their own transport in a next PR which might use different libraries and catching the lib specific expections will not work then

Type of change

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• Unit tests
• Spec Tests
• Integration tests / Manual Tests

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[sighphyre]

Okay, seems fair. The URL validation is a little more muck-with-url-chunks than I would have liked but I actually don't see a way to do this without pulling in pydantic, and that's definitely overkill for this. It's self contained enough that we can swap it out later if we decide we care