Skip to content

refactor: rename transport to apiclient - #467

Merged
alexanto merged 1 commit into
feat/inject-custom-http-clientfrom
refactor/rename-transport
Nov 5, 2026
Merged

alexanto merged 1 commit into
feat/inject-custom-http-clientfrom
refactor/rename-transport

Conversation

@alexanto

@alexanto alexanto commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

this is just a rename from transport -> api_client, because i would like to reuse the name transport for sth else
i want to split the current transport into multiple parts, the api_client handling some unleash specific logic, like etags, event and the transport layer only responsible for the actual request so it is possible to swap to a custom one

@alexanto
alexanto added this pull request to stack #468 November 2, 2026 14:12
@gastonfournier gastonfournier moved this from New to In Progress in Issues and PRs Nov 3, 2026
@sighphyre
sighphyre force-pushed the refactor/rename-transport branch from de6e361 to 9d6db90 Compare November 3, 2026 07:36

@sighphyre sighphyre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks like a rename to me

@github-project-automation github-project-automation Bot moved this from In Progress to Approved PRs in Issues and PRs Nov 3, 2026
@sighphyre

Copy link
Copy Markdown
Member

i want to split the current transport into multiple parts, the api_client handling some unleash specific logic, like etags, event and the transport layer only responsible for the actual request so it is possible to swap to a custom one

I don't disagree, just keep an eye on how deeply abstracted this gets. This SDK got a whole bunch of complexity in a short space of time to support the async client. I'm hoping we can throw away some of the internal abstractions out once we feel comfortable that we know where we want to go. Not putting more on your plate, just keep half an eye open for abstractions you feel aren't pulling their weight as you refactor

@alexanto

alexanto commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

I'm hoping we can throw away some of the internal abstractions out once we feel comfortable that we know where we want to go

i have a feeling that I would like to know where streaming goes first, but generally agree

@alexanto
alexanto merged commit 29bc511 into main Nov 5, 2026
8 checks passed
@alexanto
alexanto deleted the refactor/rename-transport branch November 5, 2026 13:13
@github-project-automation github-project-automation Bot moved this from Approved PRs to Done in Issues and PRs Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants