Conversation
Resolve EN/RU agent authority guidance per operation while preserving upstream wallet guidance and PHP null semantics.
Author
|
Closing this combined proposal to separate minimal correctness/security fixes against current master from optional AgentKeys functionality. The existing branch is retained; replacement changes will preserve the minimalist protocol contract in the fixes PR and describe policy extensions separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agent authorization currently treats a transaction as a single grant scope, allowing authority to spill across operations and excluding valid direct regular requirements. Persisted AgentKeys/key history also need safe snapshot and restart handling. This is a consensus-affecting change, not a wallet/UI feature.
Changes
proposal_create/proposal_delete; deny delegatedproposal_updateandaccount_update, including invalid stored grants. Preserve existing wipe-on-authority-change behavior.thirdparty/fcto the published FC dependency at826353693ebdedaaf575e27c9414276bc5917e5dfor the build fixes.Verification
1704986060363f094a00a8a342c733bf9ccee83f(upstream master992b40aa): testnetvizd,consensus_sim_tests, andpm_agent_access_testsbuild with-j1; focused AgentKeys/key-history consensus 42/42 cases, 243/243 assertions; protocol 10/10 cases, 112/112 assertions;vizd --versionand--helpexit 0;git diff --checkclean.e5efbde3, before this latest-master merge): isolated mainnet-derived dream-world SDK/RPC testnet finalized 58/58 positive active/regular pairs and rejected 58/58 ungranted-signature attempts; four policy negatives, post-restart transfer, snapshot import/tamper/restart and 149/149 consensus cases, 1903/1903 assertions. Those live/full-suite results were not rerun on this integrated head; latest master changed block-archive wiring and docs, not AgentKeys consensus code.Rollout: HF15 production timestamp remains 2026-10-05 00:00 UTC; this changes consensus relative to published 4.1.0 and requires explicit maintainer coordination for rollout. No production activation or deployment is claimed.
CI note: Docker publishing job failed before compilation at
docker/login-actionwithUsername and password required(upstream workflow credentials unavailable to this fork PR); this is not a build/test result. Consensus/PM CI is still running at the time of this note.