fix: Remove underscore from check for Ensembl Protein ID - #110
Merged
Conversation
Release 2026.2.1
There is no underscore in Ensembl IDs so removing it here.
|
coverage: 0.0%. remained the same — davereinhart/fix-ensembl-protein-id-check into mavedb-main |
davereinhart
marked this pull request as draft
July 7, 2026 16:22
davereinhart
marked this pull request as ready for review
July 7, 2026 17:33
bencap
approved these changes
Jul 8, 2026
bencap
pushed a commit
to VariantEffect/mavedb-api
that referenced
this pull request
Jul 9, 2026
infer_db_name_from_sequence_accession now recognizes ENSP accessions and maps them to the Ensembl_Protein source, so accession-based target genes with Ensembl protein IDs resolve to a UniProt ID instead of raising NotImplementedError. Also make validate_ensembl_identifier accept versioned Ensembl stable IDs (e.g. ENSP00000369497.3) by stripping the trailing .<version> before the idutils.is_ensembl check, matching how validate_refseq_identifier already handles versioned RefSeq accessions. Related to VariantEffect/dcd_mapping2#110
bencap
pushed a commit
to VariantEffect/mavedb-api
that referenced
this pull request
Jul 17, 2026
infer_db_name_from_sequence_accession now recognizes ENSP accessions and maps them to the Ensembl_Protein source, so accession-based target genes with Ensembl protein IDs resolve to a UniProt ID instead of raising NotImplementedError. Also make validate_ensembl_identifier accept versioned Ensembl stable IDs (e.g. ENSP00000369497.3) by stripping the trailing .<version> before the idutils.is_ensembl check, matching how validate_refseq_identifier already handles versioned RefSeq accessions. Related to VariantEffect/dcd_mapping2#110
bencap
pushed a commit
to VariantEffect/mavedb-api
that referenced
this pull request
Jul 17, 2026
infer_db_name_from_sequence_accession now recognizes ENSP accessions and maps them to the Ensembl_Protein source, so accession-based target genes with Ensembl protein IDs resolve to a UniProt ID instead of raising NotImplementedError. Also make validate_ensembl_identifier accept versioned Ensembl stable IDs (e.g. ENSP00000369497.3) by stripping the trailing .<version> before the idutils.is_ensembl check, matching how validate_refseq_identifier already handles versioned RefSeq accessions. Related to VariantEffect/dcd_mapping2#110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no underscore in Ensembl IDs so removing it from the ID prefix check in transcripts module.