Repository navigation
Migrate development tooling and CI to LLVM 23 - #141
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move formatting and static analysis to LLVM 23 so local checks and CI use the same toolchain. Add portable Clang 23 CI builds with OpenMP ON/OFF and installed/component consumer checks, update the development instructions, and apply the resulting formatting changes. The library still requires C++17; downstream users do not need Clang 23.
Initialize OpenMP before allocation-failure injection, or avoid querying its runtime while injection is disabled, in three tests. This prevents runtime initialization from interfering with the allocation hooks. Keep the frozen v1 compatibility fixture outside automated formatting.
Remove the unused global
warmup_ip_x0_q<b_query, padded_dim>wrapper. External callers using that wrapper must migrate torabitqlib::warmup_ip_x0_q<b_query>(..., padded_dim). Index storage and persisted formats are unchanged.Testing
Local Linux x86-64 verification with Clang 23.1.4, GCC 14.3.0 and native optimization disabled:
11c0ee9The skipped C++ test requires OpenMP binding; its separate
OpenMPBindinginvocation passed. Python skips require repaired Linux ARM64 and macOS wheels. AVX2 and AVX-512 reference tests executed on the local CPU. Windows, macOS and ARM64 were not tested locally.Clang sanitizer failures remain visible and were not suppressed. A separate clean-base build with matching settings reproduced all 13 cases:
GemmKernel.h:815.uint8_tconversion atsrc/simd/portable_generic.cpp:140for zero-step scalar quantization.These are existing baseline issues, outside this toolchain migration. The subsequent documentation-only correction passed local-link validation and
git diff --check.