Repository navigation
Use the HNSW seed for quantization rotation - #144
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HNSW's
random_seedseeds the graph-level generator, but construction currently gives the FHT/Kac rotator a fresh random-device seed. Identical inputs and seeds can therefore produce different serialized indexes and search results even with one construction thread.Pass the seed's low 32 bits to the rotator. Add C++ L2/IP and Python padded-dimension regressions that compare serialized bytes and search results from repeated serial builds, and check that another seed changes the index. Document the seed scope and the remaining scheduling/toolchain limits.
Newly constructed indexes now use a reproducible rotation. Existing files still restore their saved rotations; public signatures and the saved-index format are unchanged. Parallel insertion order remains scheduling-dependent.
Testing
Validated this branch independently of the NumPy alignment fix and IVF append optimization on Linux x86-64, using GCC 14.3, GoogleTest 1.14.0, Python 3.13, and
RABITQ_ENABLE_NATIVE_OPTIMIZATION=OFF:OpenMPBindingtest passes.git diff --checkpass.No performance improvement is claimed: this changes seed plumbing, not the search kernels. Windows, macOS, and ARM64 execution remain for CI.