Skip to content

ci: compile benchmark smoke targets and validate workflow edits - #150

Merged
gouyt13 merged 1 commit into
mainfrom
ci/benchmark-smoke-and-workflow-coverage
Oct 21, 2026
Merged

gouyt13 merged 1 commit into
mainfrom
ci/benchmark-smoke-and-workflow-coverage

Conversation

@gouyt13

@gouyt13 gouyt13 commented Oct 21, 2026

Copy link
Copy Markdown
Member

Summary

Changes to test.yaml previously skipped its ShellCheck job and Python summary-verdict tests. Select both checks when that workflow changes.

Benchmark source changes previously selected broad CI without compiling benchmark targets. Add an Ubuntu Benchmark build and smoke job with benchmarks ON, ordinary tests/samples OFF, native optimization OFF, and bindings ON for the Python ID helper. Build the targets and run their 15 existing small CTest cases with a per-test timeout; no external dataset, timing threshold or performance comparison.

Wire a dedicated benchmarks group through change detection. Core/hotpath benchmark-only edits select smoke plus applicable formatting/lint rather than unrelated wheel/platform matrices; shared source, binding and build/package changes also select smoke. Unknown-input, release and detection-failure safeguards remain conservative. Include hotpath Python helpers in Ruff and update coverage documentation.

Separate agent workflow templates are excluded. Required-check registration for the new job remains a follow-up after GitHub validation.

Testing

  • Routing regression failed in 13 cases on the original classifier; 27 helper tests and 239 subtests now pass.
  • Isolated portable Release build succeeded with GCC 14.3 and the existing Python 3.13 environment; all 15 CTest smoke cases passed, including Python IDs. No package was installed or replaced.
  • Project Python checks, focused Ruff, ShellCheck, YAML output/job wiring checks, strict MkDocs, local links and diff checks passed.
  • Independent read-only review passed and independently reran 27 helper unittest cases.

Cloud Ubuntu/Python 3.11 validation is pending this PR. Local build emitted existing vendored hnswlib unused-function warnings, retained without suppression. No all-ISA coverage or performance improvement is claimed. This PR intentionally selects full CI because it changes the classifier.

@gouyt13
gouyt13 merged commit 270f7e7 into main Oct 21, 2026
50 checks passed
@gouyt13
gouyt13 deleted the ci/benchmark-smoke-and-workflow-coverage branch October 21, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant