Repository navigation
ci: compile benchmark smoke targets and validate workflow edits - #150
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes to
test.yamlpreviously skipped its ShellCheck job and Python summary-verdict tests. Select both checks when that workflow changes.Benchmark source changes previously selected broad CI without compiling benchmark targets. Add an Ubuntu
Benchmark build and smokejob with benchmarks ON, ordinary tests/samples OFF, native optimization OFF, and bindings ON for the Python ID helper. Build the targets and run their 15 existing small CTest cases with a per-test timeout; no external dataset, timing threshold or performance comparison.Wire a dedicated
benchmarksgroup through change detection. Core/hotpath benchmark-only edits select smoke plus applicable formatting/lint rather than unrelated wheel/platform matrices; shared source, binding and build/package changes also select smoke. Unknown-input, release and detection-failure safeguards remain conservative. Include hotpath Python helpers in Ruff and update coverage documentation.Separate agent workflow templates are excluded. Required-check registration for the new job remains a follow-up after GitHub validation.
Testing
Cloud Ubuntu/Python 3.11 validation is pending this PR. Local build emitted existing vendored hnswlib unused-function warnings, retained without suppression. No all-ISA coverage or performance improvement is claimed. This PR intentionally selects full CI because it changes the classifier.