Skip to content

ci: fix formatting failure propagation and cache consumer builds - #159

Merged
gouyt13 merged 2 commits into
mainfrom
ci/fix-gates-and-cache-consumers
Oct 23, 2026
Merged

gouyt13 merged 2 commits into
mainfrom
ci/fix-gates-and-cache-consumers

Conversation

@gouyt13

@gouyt13 gouyt13 commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Fail C++ formatting when the file-list helper is missing, exits unsuccessfully, or emits partial output before failing. Preserve NUL-separated filenames and add regression coverage.
  • Route allocation/failure test changes to C++ checks and formatting without unrelated Python or wheel builds.
  • Use job-local ccache in Linux/macOS core/FastScan consumer jobs and the Clang matrix. Keep independent integration builds and the existing platform/OpenMP coverage, and report cache statistics.

ccache is a CI build tool only; library dependencies, APIs, and index formats are unchanged.

  • Grant the metadata-only PR classifier pull-request write permission for label assignment/removal, while retaining issue write permission for repository label creation. Add permission regression assertions.

Testing

  • python -B -m unittest discover -s .github/scripts -p 'test_*.py': 41 tests passed. Regression assertions failed against the original scripts and pass with these changes.
  • python -m pytest tests/python/test_benchmark_protocol.py: 12 tests passed.
  • tests/core_consumer/run.cmake: full GCC 14.3/OpenMP ON and Clang 23.1.4/OpenMP OFF runs passed, with 326 CTest cases each. Native optimization was disabled; build parallelism and OpenMP threads were both 2.
  • Python formatting/lint, automation Ruff checks, ShellCheck, full C++ formatting, strict MkDocs build, and git diff --check passed.
  • Actionlint 1.7.9 passed with its outdated windows-2025-vs2026 runner-label diagnostic narrowly ignored.
  • A separate reviewer returned PASS for this exact patch, reran the automation and routing checks, reproduced the original defects, and inspected the raw integration evidence.

The clean Clang cache recorded 101 hits in 321 compiler calls. This confirms local compilation reuse; GitHub runtime improvement and macOS/Windows execution remain to be checked by this PR's CI.
The original PR classifier failed with HTTP 403 assigning a label. Its intended release:build label was applied and its retry passed. Because pull_request_target uses the base-branch workflow, this retry does not validate the new token permissions; that path must be confirmed after merge. The permission delta independently passed review and all local checks.

@gouyt13 gouyt13 added the release:build Release category managed from the PR title label Oct 23, 2026
@gouyt13
gouyt13 merged commit 26e12f3 into main Oct 23, 2026
54 checks passed
@gouyt13
gouyt13 deleted the ci/fix-gates-and-cache-consumers branch October 23, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:build Release category managed from the PR title

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant