Repository navigation
fix: preserve exception state and scalar quantization precision - #174
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve valid state when allocation fails during LUT/query copy assignment or visited-set initialization. Synchronize Python IVF readiness after a failed rebuild, retaining an existing valid index on early failures and marking it unbuilt after invalidation.
Keep scalar quantization intermediates in the input type to avoid narrowing double values to float. No public API, saved-index format, or dependency changes.
Testing
RABITQ_ENABLE_NATIVE_OPTIMIZATION=OFF): 370 C++ unit/reference tests passed; one OpenMP placement-dependent test skipped../scripts/check-format.shandgit diff --checkpassed.