Skip to content

refactor: simplify core and utils and remove unused Array - #175

Merged
gouyt13 merged 2 commits into
mainfrom
refactor/utils-helper-cleanup
Oct 28, 2026
Merged

gouyt13 merged 2 commits into
mainfrom
refactor/utils-helper-cleanup

Conversation

@gouyt13

@gouyt13 gouyt13 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Summary

Consolidate scalar quantization type selection with if constexpr and share rounding helper implementations while preserving their entry points. Default ordinary rotator copying, simplify RabitqConfig special members, name core buffer sizes with structured bindings, and reuse class-qualified rotator serialization sizes without changing subclass dispatch behavior.

Remove the unused rabitqlib::Array, its dedicated memory::Allocator, installation entry, and three Array-only tests. This removes the installed rabitqlib/utils/array.hpp header and those C++ types; external consumers using them must migrate. RowMajorArray, the stable core v1 API, saved-index formats, and dependencies are unchanged.

Testing

  • Combined portable Release C++ unit/reference suite: 367 passed; the OpenMP binding test skipped in the default run passed separately with binding enabled.
  • Frozen core v1 consumer and dispatch/scalar zero-allocation checks passed. Fresh installation and all three installed-consumer CTests passed.
  • Focused checks covered helper compatibility, config copy/move traits, rotator copy/self-assignment, and buffer/stream round trips including subclasses overriding serialized size. GCC 12 / Clang 23 scalar quantization code-generation probes matched the original instructions and relocations.
  • Full configured clang-tidy, formatting, and git diff --check passed.
  • No local Windows, macOS, ARM64, or Python wheel rerun for the combined changes; those remain CI coverage.

@github-actions github-actions Bot added the release:maintenance Release category managed from the PR title label Oct 28, 2026
@gouyt13 gouyt13 changed the title refactor(utils): consolidate helpers and remove unused Array refactor: simplify core and utils and remove unused Array Oct 28, 2026
@gouyt13
gouyt13 merged commit 4364fd5 into main Oct 28, 2026
76 of 83 checks passed
@gouyt13
gouyt13 deleted the refactor/utils-helper-cleanup branch October 28, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:maintenance Release category managed from the PR title

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant