Repository navigation
fix(ci): select compatible Windows runtimes and clean platform checks - #178
Merged
Merged
Conversation
gouyt13
marked this pull request as ready for review
October 29, 2026 06:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows wheel repair previously picked up
msvcp140.dll14.40 from the runner search path while compiling with MSVC 14.51. Select compatible x64 CRT/OpenMP directories from Visual Studio, prioritize them withdelvewheel --add-path, and reject older or missing bundled runtimes after repair. Ensure changes to the repair hook trigger wheel CI.Keep portable assertions active in ARM-visible tests while retaining AVX-specific checks. Link the allocation-failure test through FastScan or core, avoiding the duplicate core archive reported by Apple's linker. No library algorithm or public API changes.
Testing
git diff --checkpassed. Independent review found no confirmed source defect.Pending native validation (Q1)
This PR remains a draft until Windows CI validates the actual
vswhere -> runtime discovery -> delvewheel repair -> installed-wheel testspath for CPython 3.11 and 3.14. Retain the selected runtime directories and bundled DLL versions in the logs. Positive local policy tests use mocks; rejecting old artifacts alone does not establish that a new Windows wheel builds successfully. Native ARM/macOS checks also remain CI validation.