Repository navigation
refactor: share scoring helpers and remove redundant state - #181
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Share the scalar binary-query accumulation loop between its runtime and template entry points, and share QG accumulation/correction between generic types and ISA-specific float estimators. Keep public validation, dispatch, numerical operation order and public signatures intact.
Remove the unused private HNSW query argument and redundant visited-set table size. The internal visited-set object layout shrinks; persisted layouts and stable core API remain unchanged. C++ consumers were rebuilt. No dependency change or performance improvement is claimed.
Testing
Native ARM, Windows and macOS execution was not rerun. Public wrappers, including the legacy ignored argument, are retained.