Repository navigation
test: strengthen startup oracles and reject empty selections - #182
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthen pre-main Core and FastScan tests so silent no-ops or incorrect finite results cannot pass. Use independent nonzero distance references, sentinel output buffers, and known LUT/HACC results.
Add
--no-tests=errorto the 11 remaining unguarded CTest invocations and a workflow-contract test covering all 16 commands plus an actual empty-test-directory failure. Production library behavior is unchanged.Testing
git diff --checkpassed.Validation was local Linux; hosted Windows/macOS/ARM jobs have not run this patch yet.