Skip to content

test: strengthen startup oracles and reject empty selections - #182

Merged
gouyt13 merged 1 commit into
mainfrom
test/startup-oracles-and-empty-selection
Oct 29, 2026
Merged

gouyt13 merged 1 commit into
mainfrom
test/startup-oracles-and-empty-selection

Conversation

@gouyt13

@gouyt13 gouyt13 commented Oct 29, 2026

Copy link
Copy Markdown
Member

Summary

Strengthen pre-main Core and FastScan tests so silent no-ops or incorrect finite results cannot pass. Use independent nonzero distance references, sentinel output buffers, and known LUT/HACC results.

Add --no-tests=error to the 11 remaining unguarded CTest invocations and a workflow-contract test covering all 16 commands plus an actual empty-test-directory failure. Production library behavior is unchanged.

Testing

  • Correct implementations pass both startup tests. Four temporary startup-only fault controls (LUT generation, HACC transfer, accumulation, and Core zero results) are reached and rejected; these mutations are not committed.
  • New CI contract test fails on the old workflow and passes after the guards are added.
  • Portable CTest: 406 passed, 1 skipped; the placement test passed separately with OpenMP binding enabled.
  • CI helper suite: 57 passed, 502 subtests passed. C++ formatting, Python lint/format, workflow YAML parsing, and git diff --check passed.

Validation was local Linux; hosted Windows/macOS/ARM jobs have not run this patch yet.

@github-actions github-actions Bot added the release:maintenance Release category managed from the PR title label Oct 29, 2026
@gouyt13
gouyt13 merged commit ea03b6d into main Oct 29, 2026
48 checks passed
@gouyt13
gouyt13 deleted the test/startup-oracles-and-empty-selection branch October 29, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:maintenance Release category managed from the PR title

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant