Repository navigation
fix(browser): bump playwright-go to v0.6000.0 (playwright 1.60.0) - #1537
Open
maxtortime wants to merge 1 commit into
Open
maxtortime wants to merge 1 commit into
maxtortime wants to merge 1 commit into
Conversation
The pinned playwright-go v0.4702.0 ships driver 1.47.2, which can no longer drive current Chromium-based browsers: - Launching the system browser (`--browser-type msedge`, Edge 151) fails: the browser process exits immediately with code 0 and playwright reports "Target page, context or browser has been closed". Reproduced with plain playwright-core 1.47.2/1.48.2/1.50.1/1.52.0; 1.55.1 and 1.60.0 drive the same browser fine. - The bundled fallback (Chromium 129) does not start at all on recent Windows builds: "the application has failed to start because its side-by-side configuration is incorrect" (activation context for the private assembly 129.0.6668.29). Chromium 140 starts normally. - The 1.47.2 driver archive is no longer served: the download host playwright.azureedge.net returns 404 for builds/driver/playwright-1.47.2-win32_x64.zip, so `download_browser_driver = true` cannot recover either. Together this leaves the Browser provider with no working browser on an up-to-date machine. Bumping to playwright-go v0.6000.0 (driver 1.60.0) restores it. The only source change required is BrowserContext.StorageState, which now takes an options struct instead of a path string. Verified on Windows 11 with Microsoft Entra ID (Azure AD) SSO: `saml2aws login --browser-type msedge` completes the SAML flow, and the saved storage state is reused so subsequent logins skip MFA. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pinned playwright-go v0.4702.0 ships driver 1.47.2, which can no longer drive current Chromium-based browsers:
--browser-type msedge, Edge 151) fails: the browser process exits immediately with code 0 and playwright reports "Target page, context or browser has been closed". Reproduced with plain playwright-core 1.47.2/1.48.2/1.50.1/1.52.0; 1.55.1 and 1.60.0 drive the same browser fine.download_browser_driver = truecannot recover either.Together this leaves the Browser provider with no working browser on an up-to-date machine. Bumping to playwright-go v0.6000.0 (driver 1.60.0) restores it.
The only source change required is BrowserContext.StorageState, which now takes an options struct instead of a path string.
Verified on Windows 11 with Microsoft Entra ID (Azure AD) SSO:
saml2aws login --browser-type msedgecompletes the SAML flow, and the saved storage state is reused so subsequent logins skip MFA.