Repository navigation
ci: add cognitive_complexity to dart and flutter package #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
unicoderbot
wants to merge
2
commits into
main
Choose a base branch
from
vgv-ai-bot/issue-519
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,26 @@ on: | |
| type: string | ||
| default: "" | ||
| description: "Newline-separated list of globs to upload as a workflow artifact, relative to the repository root (e.g. '**/failures/**'). Empty disables the upload." | ||
| cognitive_complexity_diff_base: | ||
| required: false | ||
| type: string | ||
| default: "" | ||
| description: "Git reference to compare against when computing complexity changes (e.g. 'origin/main'). Empty lets the action auto-detect the base." | ||
| cognitive_complexity_fail_on_increase: | ||
| required: false | ||
| type: boolean | ||
| default: false | ||
| description: "Whether to fail the job when cognitive complexity increases relative to cognitive_complexity_diff_base." | ||
| cognitive_complexity_fail_threshold: | ||
| required: false | ||
| type: number | ||
| default: 15 | ||
| description: "The maximum cognitive complexity score a function may reach before the job fails." | ||
| cognitive_complexity_targets: | ||
| required: false | ||
| type: string | ||
| default: "lib" | ||
| description: "Space-separated list of directories or files to scan for cognitive complexity. Resolved from the repository root, not working_directory." | ||
| collect_coverage_from: | ||
| required: false | ||
| type: string | ||
|
|
@@ -77,6 +97,10 @@ on: | |
| required: false | ||
| type: boolean | ||
| default: true | ||
| run_cognitive_complexity: | ||
| required: false | ||
| type: boolean | ||
| default: false | ||
| run_skipped: | ||
| required: false | ||
| type: boolean | ||
|
|
@@ -127,6 +151,10 @@ jobs: | |
| steps: | ||
| - name: 馃摎 Git Checkout | ||
| uses: actions/checkout@v7 | ||
| with: | ||
| # Cognitive complexity comparison needs the full history to resolve the | ||
| # diff base; a shallow clone is enough for every other step. | ||
| fetch-depth: ${{inputs.run_cognitive_complexity && '0' || '1'}} | ||
|
Comment on lines
+154
to
+157
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||
|
|
||
| - name: 馃惁 Setup Flutter | ||
| uses: subosito/flutter-action@v2.23.0 | ||
|
|
@@ -166,6 +194,15 @@ jobs: | |
| flutter pub global activate bloc_tools | ||
| bloc lint . | ||
|
|
||
| - name: 馃 Cognitive Complexity | ||
| if: ${{inputs.run_cognitive_complexity}} | ||
| uses: kevmoo/analytica.dart/packages/cognitive_complexity@main | ||
| with: | ||
| targets: ${{inputs.cognitive_complexity_targets}} | ||
| fail-threshold: ${{inputs.cognitive_complexity_fail_threshold}} | ||
| fail-on-increase: ${{inputs.cognitive_complexity_fail_on_increase}} | ||
| diff-base: ${{inputs.cognitive_complexity_diff_base}} | ||
|
|
||
| # Built in a bash step so the test command below stays shell-agnostic | ||
| # (Windows runners default to pwsh, which cannot parse bash loops). | ||
| - name: 馃幆 Resolve Dart Defines | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this since the action already provides a diff base to achieve this behavior