Skip to content

vmanomaly: support Temporal Envelope v2 configuration - #2801

Open
fred-navruzov wants to merge 2 commits into
masterfrom
vmanomaly-1320-model-config
Open

fred-navruzov wants to merge 2 commits into
masterfrom
vmanomaly-1320-model-config

Conversation

@fred-navruzov

Copy link
Copy Markdown
Contributor

Why

Operator's typed model configuration does not preserve model_version, preventing explicit selection of Temporal Envelope v2. Its seasonality validation also rejects the new calendar_month option.

Changes

Preserve omitted, v1 and v2 selections for univariate and multivariate Envelope models. Validate version-specific monthly seasonalities and the multivariate dependency_strength output, and document the v1.32.0 image requirement and fresh-fit requirement when switching versions.

No CRD changes are needed: these fields belong to the existing model configuration. Server TLS/mTLS support remains separate in #2794. The default image version is unchanged; select v1.32.0 or newer explicitly.

Validation

  • Round-trip tests cover both class aliases and full paths, omitted versions, explicit v1/v2, and new seasonalities.
  • Negative tests cover unsupported/empty versions, incompatible seasonalities, duplicates and the v2-only multivariate output.
  • go test ./internal/controller/operator/factory/vmanomaly/config ./internal/controller/operator/factory/vmanomaly passed.
  • go vet ./internal/controller/operator/factory/vmanomaly/... and git diff --check passed.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread docs/CHANGELOG.md Resolved
@fred-navruzov
fred-navruzov force-pushed the vmanomaly-1320-model-config branch from 6491f08 to 7cb04f8 Compare November 9, 2026 16:31

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants