docs(skill): mark the team key-distribution bug as fixed - #269
Merged
Conversation
The team E2E skill still described #41 as a live hazard. It was fixed in v0.13.0 and closed on 2026-07-29: reconcileTeamVaultKeys() wraps the key for any keyless member and runs both on login and on membership change, so the offline-key-holder lockout self-heals. Reading the skill as current led to reporting a seven-month-old bug as an open risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The team E2E skill's "Known real bug this harness surfaced" section still described #41 — the async key-distribution window — as a live hazard.
It was fixed in v0.13.0 and closed on 2026-07-29. The fix is present in the code shipping today:
reconcileTeamVaultKeys()(teamVaultSync.ts:383) comparesteam_membersagainst the server's key-holder list and wraps the key for anyone missing it, returning early if the caller cannot unwrap the key itselfteamDataManager.ts:47, whose comment names Team vault: invitee locked out (no key) when they accept while the inviter is offline #41) and on membership change (sync.ts:939)So the documented scenario — an invitee accepts while the sole key-holder is offline — self-heals when that key-holder next signs in, rather than waiting for a coincidental membership event.
Reading the skill as current caused a seven-month-old bug to be reported as an open risk against shipping Teams. The section now records it as fixed, keeps the
team_vault_keysdebugging hint, and says explicitly not to report #41 as open.