Repository navigation
Conversation
- package.json with @weacademy/bytechain-shared, tsup build, exports map (root, ./auth, ./courses), and public publish config - tsup.config.ts with cjs+esm+dts output for all three entry points - tsconfig.json with strict mode and bundler module resolution - src/index.ts, src/auth/index.ts, src/courses/index.ts entry points - .github/workflows/ci.yml (type check, build, test) - .gitignore Closes #1
Move backend response DTO types into the shared package: Auth types (src/auth/types.ts): - AuthResponse, RefreshTokenResponse, LogoutResponse, ForgotPasswordResponse, ResetPasswordResponse - Request DTOs: RegisterRequest, LoginRequest, RefreshTokenRequest, LogoutRequest, ForgotPasswordRequest, ResetPasswordRequest Course types (src/courses/types.ts): - CourseResponse, EnrollmentStatusResponse, CourseRegistrationResponse, EnrolledCourseResponse - Request DTOs: CreateCourseRequest, UpdateCourseRequest, CourseFilterRequest Both modules now re-export from index.ts for clean imports. Closes #2
Contributor
Author
|
Closing: the linked issue is not assigned to the PR author. Please get the issue assigned before opening a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves backend response DTO types for auth and courses into the shared package as framework-agnostic TypeScript interfaces.
Auth types (
src/auth/types.ts)Response types:
AuthResponse,RefreshTokenResponse,LogoutResponse,ForgotPasswordResponse,ResetPasswordResponseRequest types:
RegisterRequest,LoginRequest,RefreshTokenRequest,LogoutRequest,ForgotPasswordRequest,ResetPasswordRequestCourse types (
src/courses/types.ts)Response types:
CourseResponse,EnrollmentStatusResponse,CourseRegistrationResponse,EnrolledCourseResponseRequest types:
CreateCourseRequest,UpdateCourseRequest,CourseFilterRequestVerification
npm run lint(tsc --noEmit) passesnpm run build(tsup) produces CJS + ESM + DTS for all three entry pointsDepends on PR #5 (scaffold).
Closes #2