Repository navigation
like: $ matches only at the end of the value - #38
Merged
Merged
Conversation
LIVR patterns follow JavaScript, where $ matches only at the end of the
value. PCRE also matches it before a trailing newline, so
{"like": "^[0-9]{5}$"} accepted "12345\n". The like rule now compiles
the pattern with the D (PCRE_DOLLAR_ENDONLY) modifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LIVR patterns follow JavaScript, where
$matches only at the end of the value. PCRE also matches$before a trailing newline, so{"like": "^[0-9]{5}$"}accepted"12345\n". The JS reference rejects it.The
likerule now compiles the pattern with theDmodifier (PCRE_DOLLAR_ENDONLY), so$matches only at the very end. Theiflag works as before, and so do patterns without anchors.Testing
vendor/bin/phpunit: 77 tests pass on PHP 8.5 (Dockercomposer:2). The newtestLikeMatchesTheEndOfTheValuefails without the fix.vendor/bin/phpcs: no warnings.{}vs[]cases (negative/22,negative/27), as before.This change was prepared with the help of an LLM and tested as described above. Please review it anyway. If it looks good, merge it; a new release isn't required for the conformance site, which tests
dev-master.