Conversation
Applied @willbooster/wbfy v20.14.1.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a comprehensive 'willboosterify' update to the repository, aligning the project structure, tooling, and configuration with standardized WillBooster practices. The changes focus on improving developer experience through consistent scripts, updated dependencies, and refined TypeScript configurations, while also enhancing project documentation and automation rules. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. The code is now clean and aligned, With scripts and configs refined. Dependencies soar, With features galore, And all of the bugs are confined. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes the monorepo structure and configuration across the packages and a new example directory, updates developer guidelines and agent instructions, and introduces a 'Requirements' section to the PR template. The reviewer feedback recommends simplifying the post-merge cleanup script by using a glob pattern for package directories instead of hardcoding them. Additionally, the reviewer suggests removing redundant @tsconfig/bun/tsconfig.json extensions in the package-level tsconfig.json files, as they already inherit this configuration from the root.
|
|
||
| run_if_changed "(mise\.toml|\.mise\.toml)" "mise install" | ||
| if git diff --no-color -U0 ORIG_HEAD HEAD -- '*bunfig.toml' | grep --quiet -E '^[+-] *(globalStore|linker|publicHoistPattern)'; then rm -Rf -- 'node_modules'; fi | ||
| if git diff --no-color -U0 ORIG_HEAD HEAD -- '*bunfig.toml' | grep --quiet -E '^[+-] *(globalStore|linker|publicHoistPattern)'; then rm -Rf -- 'example/node_modules' 'node_modules' 'packages/problem-utils-browser/node_modules' 'packages/problem-utils-llm/node_modules' 'packages/problem-utils/node_modules'; fi |
There was a problem hiding this comment.
Instead of hardcoding every package's node_modules path, we can use a glob pattern like packages/*/node_modules. This is much more maintainable and automatically supports any new packages added to the monorepo in the future.
| if git diff --no-color -U0 ORIG_HEAD HEAD -- '*bunfig.toml' | grep --quiet -E '^[+-] *(globalStore|linker|publicHoistPattern)'; then rm -Rf -- 'example/node_modules' 'node_modules' 'packages/problem-utils-browser/node_modules' 'packages/problem-utils-llm/node_modules' 'packages/problem-utils/node_modules'; fi | |
| if git diff --no-color -U0 ORIG_HEAD HEAD -- '*bunfig.toml' | grep --quiet -E '^[+-] *(globalStore|linker|publicHoistPattern)'; then rm -Rf -- 'node_modules' 'packages/*/node_modules' 'example/node_modules'; fi |
| "include": ["src/**/*"], | ||
| "exclude": ["dist", "node_modules"] | ||
| "exclude": ["test/fixtures", "dist", "node_modules"], | ||
| "extends": ["@tsconfig/bun/tsconfig.json", "../../tsconfig.json"], |
There was a problem hiding this comment.
The root tsconfig.json already extends @tsconfig/bun/tsconfig.json. Since this configuration extends ../../tsconfig.json, it already inherits those settings. We can simplify this to eliminate redundancy.
| "extends": ["@tsconfig/bun/tsconfig.json", "../../tsconfig.json"], | |
| "extends": "../../tsconfig.json", |
References
- Simplify code as much as possible to eliminate redundancy. (link)
| "include": ["src/**/*"], | ||
| "exclude": ["dist", "node_modules"] | ||
| "exclude": ["test/fixtures", "dist", "node_modules"], | ||
| "extends": ["@tsconfig/bun/tsconfig.json", "../../tsconfig.json"], |
There was a problem hiding this comment.
The root tsconfig.json already extends @tsconfig/bun/tsconfig.json. Since this configuration extends ../../tsconfig.json, it already inherits those settings. We can simplify this to eliminate redundancy.
| "extends": ["@tsconfig/bun/tsconfig.json", "../../tsconfig.json"], | |
| "extends": "../../tsconfig.json", |
References
- Simplify code as much as possible to eliminate redundancy. (link)
| "include": ["src/**/*"], | ||
| "exclude": ["dist", "node_modules"] | ||
| "exclude": ["test/fixtures", "dist", "node_modules"], | ||
| "extends": ["@tsconfig/bun/tsconfig.json", "../../tsconfig.json"], |
There was a problem hiding this comment.
The root tsconfig.json already extends @tsconfig/bun/tsconfig.json. Since this configuration extends ../../tsconfig.json, it already inherits those settings. We can simplify this to eliminate redundancy.
| "extends": ["@tsconfig/bun/tsconfig.json", "../../tsconfig.json"], | |
| "extends": "../../tsconfig.json", |
References
- Simplify code as much as possible to eliminate redundancy. (link)
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
1 participant
Why
Applying
@willbooster/wbfyv20.14.1 added the standard package-level Oxlint configuration, which exposed three pre-existing functions in@exercode/problem-utils-browserwithout explicit return types and causedtest / testto fail.Requirements
required: investigate every failing CI check and attribute each individually to this repository or to
wbfyitselfrequired: fix every identified culprit and finish without merging pull request #374
required: do not force-push the
wbfybranchchosen: conform the browser package to the shared lint convention with explicit return type annotations
Customer Summary
Repository configuration is updated by wbfy, with no runtime behavior changes. The browser package now satisfies the shared explicit-return-type lint rule.
Technical Summary
The generated package-level Oxlint configs inherit
@willbooster/oxlint-config, which intentionally requires explicit function return types. The browser server resource, CDP screenshot helper, and required-element helper now declare their inferred return types explicitly.Testing
bun run buildbun run verifyNo new runtime tests were added because the change is type-only and the lint/type-check pipeline directly enforces it.