Skip to content

perf: defer HTML formatter imports for browser graders #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
exKAZUu merged 1 commit into from
Sep 13, 2026
+6 −3
Merged

perf: defer HTML formatter imports for browser graders #381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/problem-utils-browser/src/html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ import {
startLocalHttpServer,
type TestCaseResult,
} from '@exercode/problem-utils';
import sniffHtmlEncoding from 'html-encoding-sniffer';
import type { Page } from 'puppeteer';
import { format } from 'prettier';
import prettierPluginOrganizeAttributes from 'prettier-plugin-organize-attributes';

import { createBrowserPage, capturePngScreenshot, launchBrowser } from './browser.js';
import { createTemporaryDirectory } from './temporaryDirectory.js';
Expand Down Expand Up @@ -258,6 +255,12 @@ async function loadFormattedHtmlForScreenshot(url: string): Promise<string | und
if (!contentType.includes('text/html')) return undefined;

const bytes = new Uint8Array(await response.arrayBuffer());
const [{ default: sniffHtmlEncoding }, { format }, { default: prettierPluginOrganizeAttributes }] =
await Promise.all([
import('html-encoding-sniffer'),
import('prettier'),
import('prettier-plugin-organize-attributes'),
]);
const encoding = sniffHtmlEncoding(bytes, {
transportLayerEncodingLabel: new MIMEType(contentType).params.get('charset') ?? undefined,
defaultEncoding: 'utf8',
Expand Down
Loading