Conversation
The deploy step retries 20 times only when a platform secret (FLY_API_TOKEN / RAILWAY_API_TOKEN / GCP_SA_KEY_JSON) reaches the workflow. Repositories that moved those credentials into fnox therefore lost the retry even though their uploads are just as flaky (WillBooster/coto-world#654). Let callers set the attempt count explicitly; the default is unchanged.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
deploy.ymlの Deploy ステップは、デプロイ先を示す secret(FLY_API_TOKEN/RAILWAY_API_TOKEN/GCP_SA_KEY_JSON)がワークフローに渡されたときだけ 20 回リトライし、それ以外は 1 回です。認証情報を fnox へ移したリポジトリでは、これらの secret を渡さなくなるため、アップロードの一時的な失敗に対するリトライが失われます(WillBooster/coto-world#654 で発生)。デプロイの不安定さは認証情報の置き場所とは無関係なので、この判定は実態と合っていません。
変更
deploy_max_attempts入力を追加し、呼び出し側が試行回数を明示できるようにしました。未指定時の挙動は従来どおりです(後方互換)。備考
同じ secret に依存している箇所がもう一つあります:
check-gcloudステップはHAS_GCP_SA_KEY_JSON == "true"を前提としているため、fnox 移行後は gcloud のインストールと認証がスキップされます。coto-world はmise.tomlで gcloud を pin しdeploy/ci-setupで自前認証しているため実害はありませんが、fnox 移行するリポジトリが増えると問題になり得ます。本 PR のスコープ外とし、必要であれば別途対応します。