Skip to content

style: satisfy clippy 1.99 lints - #244

Merged
FoOcean merged 1 commit into
masterfrom
fix/clippy-199-lints
Oct 16, 2026
Merged

FoOcean merged 1 commit into
masterfrom
fix/clippy-199-lints

Conversation

@FoOcean

@FoOcean FoOcean commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Pre-submission checklist

  • I have read CONTRIBUTING.md and completed the required checks
  • Local and CI checks pass
  • I have completed a self-review
  • I confirm that I haven't read the checkboxes and just ticked them all

Change type (select one)

  • feat New feature
  • fix Bug fix
  • docs Documentation or templates
  • style Formatting with no behavior change
  • refactor Code change that neither fixes a bug nor adds a feature
  • perf Performance improvement
  • test Test-related change
  • chore Build, CI, dependency, or tooling change
  • revert Revert
  • security Security fix

Scope (select all that apply)

  • Application core
  • UI style or layout
  • Application behavior
  • Dependency changes
  • Plugin API
  • CI/CD configuration
  • Documentation
  • Other (describe below)

Related issues


Description

Summary

Fixes the two clippy 1.99 lints that make the PR Check job fail on master.

Motivation and context

The CI toolchain now runs clippy 1.99. It reports manual_is_multiple_of in src/ui/expanded/timer_view.rs and chunks_exact_to_as_chunks in src/utils/recorder.rs, so cargo clippy --workspace -- -D warnings fails for every PR, including #243.

Changes

  • duration_label uses seconds.is_multiple_of(60).
  • The recorder's RGBA-to-RGB conversion uses as_chunks::<4>().

No behavior change. cargo fmt --check and MSVC clippy with -D warnings pass locally.

UI changes

None.

🤖 Generated with Claude Code

CI now runs clippy 1.99, which flags manual_is_multiple_of in timer_view.rs
and chunks_exact_to_as_chunks in recorder.rs, failing the PR Check job on
master.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@FoOcean
FoOcean merged commit 5f5c198 into master Oct 16, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Merge in Winisland Pull Requests Oct 16, 2026
@Eatgrapes
Eatgrapes deleted the fix/clippy-199-lints branch October 16, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant