Repository navigation
fix: do not cache transient HTTP read failures (WI-1802) - #427
Merged
Merged
Conversation
The agent read cache treated any nil-error result without a top-level error field as reusable. The HTTP tool returns 429/503 as ordinary JSON with a status_code and body, so a transient failure was cached: the model's retry was suppressed as a duplicate and the loop could stop as no_progress without the provider ever being retried. Cache a read only when its observable result is reusable; a transient HTTP status (408/429/5xx) is not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent read cache treated any nil-error result without a top-level error field as reusable. The HTTP tool returns 429/503 as ordinary JSON with a
status_codeand body, so a transient failure was cached: the model's retry was suppressed as a duplicate and the loop could stop asno_progresswithout the provider ever being retried.Change
Cache a read only when its observable result is reusable; a transient HTTP status (408/429/5xx) is not.
Tests
Windshiftapp/core-tests-internal#28 — a 429/503 read is re-executed and the loop finishes
done; a 200 read is still cached.