Repository navigation
fix: change the model connection, readiness, and version atomically (WI-1803) - #428
Merged
Merged
Conversation
…ically (WI-1803) UpdateAgentConfig rewrote instructions (Draft + version bump) and then changed the LLM connection in a separate write that touched neither. A concurrent ActivateStudioProfile could validate the old connection and mark the profile Ready before the new connection was stored, leaving an unvalidated model Ready. Write the instructions, connection, and runner image in one statement with a single Draft/version transition, and guard activation on the profile version that was validated: a change during validation now yields a version conflict instead of marking the changed definition Ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateAgentConfigrewrote instructions (Draft + version bump) and then changed the LLM connection in a separate write that touched neither. A concurrentActivateStudioProfilecould validate the old connection and mark the profile Ready before the new connection was stored, leaving an unvalidated model Ready.Change
ErrAgentProfileVersionConflictinstead of marking the changed definition Ready.Tests
Windshiftapp/core-tests-internal#29 — a validation captured before a model change is rejected and the profile stays Draft; a validation of the current definition still activates.