Skip to content

Match trade inventory suppression to active trade partner - #65

Merged
Wishmaster117 merged 1 commit into
mainfrom
fix/trade-inventory-whisper-partner
Aug 15, 2026
Merged

Match trade inventory suppression to active trade partner#65
Wishmaster117 merged 1 commit into
mainfrom
fix/trade-inventory-whisper-partner

Conversation

@Wishmaster117

@Wishmaster117 Wishmaster117 commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Improved trade inventory detection by ensuring inventory updates come from the current NPC trade partner.
    • Preserved existing trade-window visibility and filtering behavior.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 27e900e6-40fd-4942-8014-8e859646b6c0

📥 Commits

Reviewing files that changed from the base of the PR and between 8fa8d3b and 563ab56.

📒 Files selected for processing (1)
  • UI/MultiBotInventoryFrame.lua

📝 Walkthrough

Walkthrough

The inventory frame now requires the whisper author to match the current NPC trade partner before it detects an automatic inventory dump. Existing trade-frame visibility and bot filtering remain unchanged.

Changes

Inventory-dump detection

Layer / File(s) Summary
Trade partner validation
UI/MultiBotInventoryFrame.lua
Automatic inventory-dump filtering now checks the normalized NPC trade-partner name against the whisper author, in addition to the existing inventory-bot check.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 563ab

The change narrowly limits automatic inventory-dump filtering to the active matching trade partner, with no actionable merge-blocking risk remaining beyond normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the change to match inventory suppression with the active trade partner.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/trade-inventory-whisper-partner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Wishmaster117
Wishmaster117 merged commit 8fc85f5 into main Aug 15, 2026
5 checks passed
@Wishmaster117
Wishmaster117 deleted the fix/trade-inventory-whisper-partner branch August 15, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant