Make lint exit non-zero on invalid rules - #242
Merged
alexkornitzer merged 1 commit intoSep 23, 2026
Merged
Conversation
This was referenced Sep 23, 2026
Collaborator
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #241 per review — this is the exit-code fix on its own, no CI changes.
chainsaw lintcurrently exits0even when rules fail to validate, so it cannot be used as a gate. TheCommand::Lintarm already countsfailed— it just never acts on it. This returns an error when that count is non-zero.Output on success is unchanged; on failure the existing per-file
[!]lines are unchanged and a summary error is added.Verified locally:
cargo build --release+chainsaw lint --kind chainsaw rules/against currentrules/(131/131) exits 0; reintroducing a malformed rule exits 1.