Skip to content

Fix matching a foreign key reference to a unique key with a different case #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanJakes merged 2 commits into from
Oct 14, 2026
Merged

Fix matching a foreign key reference to a unique key with a different case #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84b1693
Fix matching a foreign key reference to a unique key with a different…
Nandan108 Oct 13, 2026
bffd503
Use strcasecmp() and test more foreign key references
JanJakes Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/mysql-on-sqlite/src/sqlite/class-wp-sqlite-information-schema-builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1820,9 +1820,10 @@ private function extract_referential_constraint_data( WP_Parser_Node $node, stri
continue;
}

// Column names are case-insensitive in MySQL.
$is_prefix = true;
foreach ( $reference_parts as $i => $reference_part ) {
if ( $index_columns[ $i ] !== $this->get_value( $reference_part ) ) {
if ( 0 !== strcasecmp( $index_columns[ $i ], $this->get_value( $reference_part ) ) ) {
$is_prefix = false;
break;
}
Expand Down
47 changes: 47 additions & 0 deletions packages/mysql-on-sqlite/tests/WP_MySQL_On_SQLite_Metadata_Tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1943,6 +1943,53 @@ public function testInformationSchemaForeignKeysReferencingShorterUniqueKey(): v
);
}

public function testInformationSchemaForeignKeysReferencingColumnsInDifferentLetterCase(): void {
$this->assertQuery(
'CREATE TABLE t1 (
id INT PRIMARY KEY,
code INT,
a INT NOT NULL,
b INT NOT NULL,
UNIQUE KEY u_code (code),
UNIQUE KEY u_a_b (a, b)
)'
);
$this->assertQuery(
'CREATE TABLE t2 (
t1_id INT,
x INT,
y INT,
FOREIGN KEY (t1_id) REFERENCES t1 (ID),
FOREIGN KEY (x, y) REFERENCES t1 (A, b)
)'
);
$this->assertQuery( 'ALTER TABLE t2 ADD COLUMN z INT, ADD CONSTRAINT fk_z FOREIGN KEY (z) REFERENCES t1 (CoDe)' );

$result = $this->assertQuery(
"SELECT constraint_name, unique_constraint_name
FROM information_schema.referential_constraints
WHERE table_name = 't2'
ORDER BY constraint_name"
);
$this->assertEquals(
array(
(object) array(
'CONSTRAINT_NAME' => 'fk_z',
'UNIQUE_CONSTRAINT_NAME' => 'u_code',
),
(object) array(
'CONSTRAINT_NAME' => 't2_ibfk_1',
'UNIQUE_CONSTRAINT_NAME' => 'PRIMARY',
),
(object) array(
'CONSTRAINT_NAME' => 't2_ibfk_2',
'UNIQUE_CONSTRAINT_NAME' => 'u_a_b',
),
),
$result
);
}

public function testInformationSchemaAlterTableAddForeignKeys(): void {
$this->assertQuery( 'CREATE TABLE t1 (id INT PRIMARY KEY, name VARCHAR(255))' );
$this->assertQuery( 'CREATE TABLE t2 (id INT)' );
Expand Down
Loading