Repository navigation
Conversation
Cast copied values to TEXT or BLOB using the destination column types. Preserve bytes and NULL values when rebuilding legacy tables or changing between text and binary types. Cover string types, renamed columns, temporary tables, rollback, and temporal-default upgrades with regression tests. Fixes #546
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Legacy tables can contain text values in binary columns, or binary values in text columns. Copying those values into a rebuilt
STRICTtable fails, even when the affected column's type has not changed.Cast copied values to the destination SQLite
TEXTorBLOBtype during table rebuilds. This fixes storage-type errors inALTER TABLE,OPTIMIZE TABLE,REPAIR TABLE, and the temporal-default upgrade. It also handles changes between text and binary column types.Regression tests cover value preservation, renamed columns, temporary tables, rollback after a failed rebuild, and legacy upgrades.
Fixes #546.