Repository navigation
Conversation
Wrap each table administration operation in a savepoint before converting errors into result rows. Preserve successful table rebuilds and surrounding user transactions when another table fails. Fixes #549
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OPTIMIZE TABLEandREPAIR TABLEreport rebuild errors as result rows. The surrounding transaction then commits the work completed before the error, leaving hidden tables or a partly rebuilt table.This change makes each table administration operation atomic with an internal savepoint. A failed rebuild restores the original schema and data, while successful rebuilds of other tables are preserved. Existing user transactions and savepoints remain active.
Regression tests cover failures while copying rows, dropping the old table, and recreating indexes, including temporary tables, repeated failures, mixed results, and user transactions.
Fixes #549.