Skip to content

Define DB_PATH for explicit SQLite database paths - #4374

Merged
JanJakes merged 1 commit into
trunkfrom
support-db-path
Oct 1, 2026
Merged

JanJakes merged 1 commit into
trunkfrom
support-db-path

Conversation

@JanJakes

@JanJakes JanJakes commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Motivation for the change, related issues

The SQLite integration is adopting DB_PATH as its primary database path setting. Playground currently supplies only DB_DIR and DB_FILE when dataSqlPath is set.

Implementation details

Define DB_PATH from dataSqlPath, keeping the matching legacy constants for older SQLite plugin versions.

Testing Instructions (or ideally a Blueprint)

Boot with dataSqlPath set to a custom SQLite file and confirm WordPress opens that file. Verified with SQLite integration v2.1.16, bundled trunk, and the build from PR #512.

Related: WordPress/sqlite-database-integration#512.

Summary by CodeRabbit

  • New Features
    • WordPress boot now uses the provided SQL data path to configure its database location, improving support for custom database setups.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1282a817-a09b-4aeb-bd24-70c737227aef

📥 Commits

Reviewing files that changed from the base of the PR and between 8750c89 and 2499e50.

📒 Files selected for processing (1)
  • packages/playground/wordpress/src/boot.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

When dataSqlPath is provided during WordPress boot, bootWordPress now defines the PHP constant DB_PATH with that path. The existing DB_DIR and DB_FILE constants remain unchanged.

Changes

WordPress boot

Layer / File(s) Summary
Define the database path
packages/playground/wordpress/src/boot.ts
When dataSqlPath is set, bootWordPress defines DB_PATH with its value. The existing DB_DIR and DB_FILE definitions remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: adamziel

Merge Risk: ⚪ Minimal · up to 2499e

No actionable merge-blocking defect is established. The configured path is published for SQLite metadata, though the external integration’s exact file selection cannot be confirmed from this checkout.

Architecture Summary

Architecture risk: 🔵 Low · up to 2499e

The change affects 1 system.

Changed systems: packages/playground

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — packages/playground (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in packages/playground/wordpress/src/boot.ts: When dataSqlPath is set, bootWordPress now defines DB_PATH to its value; the existing directory and filename constants remain unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: defining DB_PATH for explicit SQLite database paths.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JanJakes JanJakes changed the title Define DB_PATH for explicit SQLite database paths Define DB_PATH for explicit SQLite database paths Oct 1, 2026
@JanJakes
JanJakes requested a review from mho22 October 1, 2026 16:44

@mho22 mho22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JanJakes
JanJakes merged commit e1634b3 into trunk Oct 1, 2026
112 of 113 checks passed
@JanJakes
JanJakes deleted the support-db-path branch October 1, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants