You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Website] Remove the Rust parser extension loading test - #4514
Remove the Query API test that downloads the published wp_mysql_parser WASM build, along with its unused manifest URL. Keep the intl manifest-loading test and the invalid-manifest checks.
Testing Instructions (or ideally a Blueprint)
Run the Query API extension tests in Chromium. All four remaining tests pass locally. Lint, formatting, and test collection also pass.
Summary by CodeRabbit
Tests
Removed an automated end-to-end check for loading the SQLite parser extension from a remote manifest and verifying its reported state and token count.
Automated coverage continues to check the intl manifest and manifest error cases. This change affects test coverage only; it does not indicate a change to extension functionality.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
📝 Walkthrough
The end-to-end test that loaded the SQLite parser extension from a real manifest has been removed, along with its manifest URL constant. The remaining extension tests cover the intl manifest and manifest error cases.
Changes: Query API test cleanup
Layer / File(s)
Summary
Remove SQLite manifest test packages/playground/website/playwright/e2e/query-api.spec.ts
Removes the test that checked the SQLite parser extension state, parser classes, and token count. Also removes the corresponding manifest URL constant.
No actionable merge-blocking issue is identified in this test cleanup.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: removing the Rust parser extension loading test from the website.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
WordPress/sqlite-database-integration#566 removes the Rust MySQL parser extension.
Implementation details
Remove the Query API test that downloads the published
wp_mysql_parserWASM build, along with its unused manifest URL. Keep theintlmanifest-loading test and the invalid-manifest checks.Testing Instructions (or ideally a Blueprint)
Run the Query API extension tests in Chromium. All four remaining tests pass locally. Lint, formatting, and test collection also pass.
Summary by CodeRabbit
intlmanifest and manifest error cases. This change affects test coverage only; it does not indicate a change to extension functionality.