Skip to content

[Website] Remove the Rust parser extension loading test - #4514

Merged
adamziel merged 1 commit into
trunkfrom
codex/remove-rust-extension-test
Oct 24, 2026
Merged

adamziel merged 1 commit into
trunkfrom
codex/remove-rust-extension-test

Conversation

@adamziel

@adamziel adamziel commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation for the change, related issues

WordPress/sqlite-database-integration#566 removes the Rust MySQL parser extension.

Implementation details

Remove the Query API test that downloads the published wp_mysql_parser WASM build, along with its unused manifest URL. Keep the intl manifest-loading test and the invalid-manifest checks.

Testing Instructions (or ideally a Blueprint)

Run the Query API extension tests in Chromium. All four remaining tests pass locally. Lint, formatting, and test collection also pass.

Summary by CodeRabbit

  • Tests
    • Removed an automated end-to-end check for loading the SQLite parser extension from a remote manifest and verifying its reported state and token count.
    • Automated coverage continues to check the intl manifest and manifest error cases. This change affects test coverage only; it does not indicate a change to extension functionality.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9e43889a-1ce5-4a27-a3b3-a5f6c28f1f5b
📥 Commits

Reviewing files that changed from the base of the PR and between e360f7c and 58476f3.

📒 Files selected for processing: 1
  • packages/playground/website/playwright/e2e/query-api.spec.ts
💤 Files with no reviewable changes: 1
  • packages/playground/website/playwright/e2e/query-api.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The end-to-end test that loaded the SQLite parser extension from a real manifest has been removed, along with its manifest URL constant. The remaining extension tests cover the intl manifest and manifest error cases.

Changes: Query API test cleanup

Layer / File(s) Summary
Remove SQLite manifest test
packages/playground/website/playwright/e2e/query-api.spec.ts
Removes the test that checked the SQLite parser extension state, parser classes, and token count. Also removes the corresponding manifest URL constant.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested labels: [Aspect] Browser, [Aspect] Website, [Package][@wp-playground] Website

Merge Risk: ⚪ Minimal · up to 58476

No actionable merge-blocking issue is identified in this test cleanup.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the Rust parser extension loading test from the website.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@adamziel
adamziel merged commit 0a285fb into trunk Oct 24, 2026
62 checks passed
@adamziel
adamziel deleted the codex/remove-rust-extension-test branch October 24, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant