Repository navigation
FPLAT-3264: Upgrade to Dart 3.13.5 and format with that SDK - #75
Merged
Merged
Conversation
Pin CI to the same SDK so the format check stays on, and await the future returned inside load's try so analyze stays clean. Co-authored-by: Cursor <cursoragent@cursor.com>
PR SummaryLow Risk Reviewed by Cursor Bugbot for commit 8c2bb24. Configure here. |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
nicbiggs-wk
approved these changes
Nov 12, 2026
robbecker-wf
approved these changes
Nov 16, 2026
Member
|
QA +1 CI passes @Workiva/release-management-p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: FPLAT-3264
Summary
>=3.13.0 <4.0.0and pin Dart 3.13.5 in.tool-versionsand CI (Ubuntu and Windows). Format and SBOM still run on Ubuntu.testto<1.32.0and formatlib,test, andexamplewith Dart 3.13.5 in this same PR so the format check stays enabled.FontFaceObserver.load's try block sodart analyzeis clean.dart:htmldeprecations remain info-level.Test plan
dart analyzeon Dart 3.13.5 (exit 0;dart:htmlinfos only)dart format --set-exit-if-changed -o none lib test exampledart test -p chrome(20 passed)dependency_validator