Skip to content

FPLAT-3264: Upgrade to Dart 3.13.5 and format with that SDK - #75

Merged
btr-rmconsole-5[bot] merged 1 commit into
masterfrom
dart3
Nov 16, 2026
Merged

btr-rmconsole-5[bot] merged 1 commit into
masterfrom
dart3

Conversation

@sureshrajendran-wk

@sureshrajendran-wk sureshrajendran-wk commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Jira: FPLAT-3264

Summary

  • Raise the SDK constraint to >=3.13.0 <4.0.0 and pin Dart 3.13.5 in .tool-versions and CI (Ubuntu and Windows). Format and SBOM still run on Ubuntu.
  • Cap test to <1.32.0 and format lib, test, and example with Dart 3.13.5 in this same PR so the format check stays enabled.
  • Await the future returned inside FontFaceObserver.load's try block so dart analyze is clean. dart:html deprecations remain info-level.

Test plan

  • dart analyze on Dart 3.13.5 (exit 0; dart:html infos only)
  • dart format --set-exit-if-changed -o none lib test example
  • dart test -p chrome (20 passed)
  • dependency_validator
  • CI on this PR: Dart 3.13.5 on Ubuntu and Windows

Pin CI to the same SDK so the format check stays on, and await the future returned inside load's try so analyze stays clean.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Primarily SDK, CI, formatting, and a minor async/await fix in font loading; no new features or security-sensitive logic.

Reviewed by Cursor Bugbot for commit 8c2bb24. Configure here.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@sureshrajendran-wk sureshrajendran-wk changed the title Upgrade to Dart 3.13.5 and format with that SDK FPLAT-3264: Upgrade to Dart 3.13.5 and format with that SDK Nov 12, 2026
@robbecker-wf

Copy link
Copy Markdown
Member

QA +1 CI passes @Workiva/release-management-p

@rmconsole-wf rmconsole-wf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-5
btr-rmconsole-5 Bot merged commit cbca25b into master Nov 16, 2026
8 checks passed
@btr-rmconsole-7
btr-rmconsole-7 Bot deleted the dart3 branch November 16, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants