Repository navigation
fix(CR-1285405): reload PL+AIE overlays safely - #10124
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
ManojTakasi
force-pushed
the
fix/CR-1285405
branch
from
October 19, 2026 04:39
6f103c1 to
8203791
Compare
ManojTakasi
added a commit
to ManojTakasi/XRT
that referenced
this pull request
Oct 19, 2026
Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 43305a1)
chvamshi-xilinx
pushed a commit
that referenced
this pull request
Oct 19, 2026
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
https://jira.xilinx.com/browse/CR-1285405 Fix repeated execution of PL+AIE xclbins. The first run passed, but the next run could hang during DT overlay loading or hit an AIE-related kernel Oops.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
This was introduced by PR #10035. During overlay removal, zocl destroyed and recreated CU interrupt state while the DT nodes were being removed.
The existing same-UUID handling from PR #9696 also skipped reloading the xclbin even when the old AIE partition was already removed.
How problem was solved, alternative solutions (if any) and why they were rejected
During overlay pre-remove, zocl now only tears down the CU and interrupt-controller state. It recreates them after the new overlay is applied.
For slot 0, zocl clears its AIE bookkeeping without calling aie_partition_release(), because overlay removal already removes the AIE aperture and partition. Calling both paths caused double removal and a kernel Oops.
The same-UUID path now reloads the xclbin when AIE metadata is present but the AIE partition is gone.
The userspace overlay removal is also checked before applying another overlay.
Risks (if any) associated the changes in the commit
The slot-specific handling is preserved: slot 0 uses overlay-managed AIE cleanup, while other slots continue using the normal AIE release path.
What has been tested and how, request additional testing if necessary
The PL+AIE embedded_exec.sh test passed five consecutive runs without rebooting the board. No overlay hang, kernel Oops, or aie_part_mmap: size exceed error was seen.
Documentation impact (if any)