Repository navigation
ELFIO migration: add elf_impl::save(); update transitional ELFIO comments - #10130
Merged
Merged
Conversation
- Add elf_impl::save(std::ostream&) forwarding to aiebu::elf::save(), so callers no longer need to reach through get_elfio() just to serialise an ELF back to a byte buffer - Add missing <cstring> and <map> includes to hip_module.cpp (memcmp, strlen, std::map were used without explicit includes) - Update transitional comments in elf_int.h to name the two remaining get_elfio() consumers (xdp elf_helper.cpp, dtrace.h) and the steps needed to remove each one get_elfio() and the elfio.hpp include remain until the xdp submodule is updated to call save() and dtrace.h is updated to accept const aiebu::elf& instead of const ELFIO::elfio&. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
stsoe
requested review from
chvamshi-xilinx,
rbramand-xilinx and
sonals
as code owners
October 20, 2026 18:18
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Add elf_impl::save for use by XDP. This avoids an XDP dependency on ELFIO.
How problem was solved, alternative solutions (if any) and why they were rejected
get_elfio() and the elfio.hpp include remain until the xdp submodule is updated to call save() and dtrace.h is updated to accept const aiebu::elf& instead of const ELFIO::elfio&.
Risks (if any) associated the changes in the commit
None, purely additive.